issue_comments

Table actions

3 rows where issue = 1353467346 and user = 14371165 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • Illviljan · 3 ✖

issue 1

  • Fixed type errors in `mypy` GitHub Action · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1322674412 https://github.com/pydata/xarray/pull/6963#issuecomment-1322674412 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85O1mjs Illviljan 14371165 2022-11-21T21:31:48Z 2022-11-21T21:31:48Z MEMBER

Thanks, @lukeconibear !

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1321501372 https://github.com/pydata/xarray/pull/6963#issuecomment-1321501372 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85OxIK8 Illviljan 14371165 2022-11-21T05:59:36Z 2022-11-21T05:59:36Z MEMBER

A good ol' copy/paste job works as expected though. :) I think we can discuss more elegant solutions in a follow up PR.

So now mypy is not crashing anymore? Thats weird, we should open an issue on mypy about this...

This one throws errors still: python -m mypy --install-types --non-interactive --python-version 3.8 --follow-imports=silent Did it ever crash if we used the normal mypy CI but with changed python version?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1321231227 https://github.com/pydata/xarray/pull/6963#issuecomment-1321231227 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85OwGN7 Illviljan 14371165 2022-11-20T20:12:00Z 2022-11-20T20:12:00Z MEMBER

Dask is on the ignore list: https://github.com/pydata/xarray/blob/d6671dd414370d006254ba3156cb96256ce0e9c7/pyproject.toml#L31-L43

This seems to ignore the list and follow-imports doesn't seem to work either: - name: Run mypy with python3.8 # silent all imports, since external repos might not support this run: | python -m mypy --install-types --non-interactive --python-version 3.8 --follow-imports=silent

A good ol' copy/paste job works as expected though. :) I think we can discuss more elegant solutions in a follow up PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);