issue_comments

Table actions

7 rows where issue = 1337166287 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • decorator to deprecate positional arguments · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1218125983 https://github.com/pydata/xarray/pull/6910#issuecomment-1218125983 https://api.github.com/repos/pydata/xarray/issues/6910 IC_kwDOAMm_X85ImyCf dcherian 2448579 2022-08-17T14:57:37Z 2022-08-17T14:57:37Z MEMBER

:+1: put it on the meeting agenda for today

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decorator to deprecate positional arguments 1337166287
1218108989 https://github.com/pydata/xarray/pull/6910#issuecomment-1218108989 https://api.github.com/repos/pydata/xarray/issues/6910 IC_kwDOAMm_X85Imt49 mathause 10194086 2022-08-17T14:44:58Z 2022-08-17T14:44:58Z MEMBER

Any objections to merge this as is?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decorator to deprecate positional arguments 1337166287
1213269142 https://github.com/pydata/xarray/pull/6910#issuecomment-1213269142 https://api.github.com/repos/pydata/xarray/issues/6910 IC_kwDOAMm_X85IUQSW mathause 10194086 2022-08-12T15:57:51Z 2022-08-12T15:57:51Z MEMBER

I also just realized, that we made many arguments keyword-only without deprecation (e.g. xr.Dataset.mean) - but that should not stop us from using this - there are still a lot of instances where it could be helpful.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decorator to deprecate positional arguments 1337166287
1213250165 https://github.com/pydata/xarray/pull/6910#issuecomment-1213250165 https://api.github.com/repos/pydata/xarray/issues/6910 IC_kwDOAMm_X85IULp1 mathause 10194086 2022-08-12T15:41:46Z 2022-08-12T15:51:24Z MEMBER

I just realized that there is a bug in the decorator for "keyword-only arguments without a default". I wonder if I should fix this or just disallow this pattern, i.e. the following does currently not work properly:

python @_deprecate_positional_args("v0.1.0") def func(a, *, b): pass

but I am not sure how helpful it is.

EDIT: It now raises a TypeError for this case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decorator to deprecate positional arguments 1337166287
1213248810 https://github.com/pydata/xarray/pull/6910#issuecomment-1213248810 https://api.github.com/repos/pydata/xarray/issues/6910 IC_kwDOAMm_X85IULUq mathause 10194086 2022-08-12T15:40:46Z 2022-08-12T15:40:46Z MEMBER

Are the functions you are considering using this functions that never had keyword arguments before? When I wrote a similar decorator before i had an explicit list of arguments that were allowed to be converted.

No, I want to consider arguments that have default values.

```python def mean(dim, skipna=None, keep_attrs=None): pass

@_deprecate_positional_args("v0.1.0") def mean(dim, *, skipna=None, keep_attrs=None): pass ```

Or do I missunderstand your question?

Do you think that you can get it to work with static typing?

I think functools.wraps also attaches the annotations?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decorator to deprecate positional arguments 1337166287
1213193924 https://github.com/pydata/xarray/pull/6910#issuecomment-1213193924 https://api.github.com/repos/pydata/xarray/issues/6910 IC_kwDOAMm_X85IT97E headtr1ck 43316012 2022-08-12T14:44:20Z 2022-08-12T14:44:20Z COLLABORATOR

Do you think that you can get it to work with static typing?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decorator to deprecate positional arguments 1337166287
1213089164 https://github.com/pydata/xarray/pull/6910#issuecomment-1213089164 https://api.github.com/repos/pydata/xarray/issues/6910 IC_kwDOAMm_X85ITkWM hmaarrfk 90008 2022-08-12T13:04:19Z 2022-08-12T13:04:19Z CONTRIBUTOR

Are the functions you are considering using this functions that never had keyword arguments before? When I wrote a similar decorator before i had an explicit list of arguments that were allowed to be converted.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decorator to deprecate positional arguments 1337166287

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);