issue_comments: 1213248810

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6910#issuecomment-1213248810 https://api.github.com/repos/pydata/xarray/issues/6910 1213248810 IC_kwDOAMm_X85IULUq 10194086 2022-08-12T15:40:46Z 2022-08-12T15:40:46Z MEMBER

Are the functions you are considering using this functions that never had keyword arguments before? When I wrote a similar decorator before i had an explicit list of arguments that were allowed to be converted.

No, I want to consider arguments that have default values.

```python def mean(dim, skipna=None, keep_attrs=None): pass

@_deprecate_positional_args("v0.1.0") def mean(dim, *, skipna=None, keep_attrs=None): pass ```

Or do I missunderstand your question?

Do you think that you can get it to work with static typing?

I think functools.wraps also attaches the annotations?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1337166287