issue_comments

Table actions

6 rows where issue = 132536288 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Expose testing methods · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
220462553 https://github.com/pydata/xarray/issues/754#issuecomment-220462553 https://api.github.com/repos/pydata/xarray/issues/754 MDEyOklzc3VlQ29tbWVudDIyMDQ2MjU1Mw== fmaussion 10050469 2016-05-19T21:51:46Z 2016-05-19T21:51:46Z MEMBER

I'd be willing to prepare a PR, if this is still actual. Today I needed the *AllClose methods for my tests, I think it would be great to have these methods exposed.

I think I have an idea on how to proceed, but maybe I am underestimating the required amount of work.

Numpy for example has the np.allclose and np.testing.assert_allclose functions. Should xarray also have a xr.allclose function or are we happy with a xr.testing.assert_allclose alone? Also, the current xarray implementation has a different function for variables, datasets and coordinates: could these be merged in a generic assert_allclose which takes decisions on what to do based on the input type?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose testing methods 132536288
205062093 https://github.com/pydata/xarray/issues/754#issuecomment-205062093 https://api.github.com/repos/pydata/xarray/issues/754 MDEyOklzc3VlQ29tbWVudDIwNTA2MjA5Mw== spencerahill 6200806 2016-04-03T21:59:39Z 2016-04-03T21:59:39Z CONTRIBUTOR

Thanks for the ping. Sorry, I haven't. I'm actually submitting my PhD thesis in ~2 months and then defending it this summer, so I won't be able to help much until August or September. So by all means, go for it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose testing methods 132536288
204460257 https://github.com/pydata/xarray/issues/754#issuecomment-204460257 https://api.github.com/repos/pydata/xarray/issues/754 MDEyOklzc3VlQ29tbWVudDIwNDQ2MDI1Nw== jhamman 2443309 2016-04-01T16:29:22Z 2016-04-01T16:29:22Z MEMBER

@spencerahill - have you made any progress here? If not we (@dgergel) may be able to help out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose testing methods 132536288
182508961 https://github.com/pydata/xarray/issues/754#issuecomment-182508961 https://api.github.com/repos/pydata/xarray/issues/754 MDEyOklzc3VlQ29tbWVudDE4MjUwODk2MQ== spencerahill 6200806 2016-02-10T18:12:13Z 2016-02-10T18:12:13Z CONTRIBUTOR

Indeed. I'm happy to do this sometime (eventually...), but if somebody ends up with a pressing need for this in the meantime, go for it. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose testing methods 132536288
182497635 https://github.com/pydata/xarray/issues/754#issuecomment-182497635 https://api.github.com/repos/pydata/xarray/issues/754 MDEyOklzc3VlQ29tbWVudDE4MjQ5NzYzNQ== shoyer 1217238 2016-02-10T17:42:47Z 2016-02-10T17:42:47Z MEMBER

Most of these are as simple as assert d1.identical(d2) or assert d1.equals(d2) (see here for more details on these methods). I'd be OK with adding these methods in a dedicated testing module, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose testing methods 132536288
182083400 https://github.com/pydata/xarray/issues/754#issuecomment-182083400 https://api.github.com/repos/pydata/xarray/issues/754 MDEyOklzc3VlQ29tbWVudDE4MjA4MzQwMA== jhamman 2443309 2016-02-09T21:33:11Z 2016-02-09T21:33:11Z MEMBER

:+1: 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expose testing methods 132536288

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);