issue_comments: 220462553

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/754#issuecomment-220462553 https://api.github.com/repos/pydata/xarray/issues/754 220462553 MDEyOklzc3VlQ29tbWVudDIyMDQ2MjU1Mw== 10050469 2016-05-19T21:51:46Z 2016-05-19T21:51:46Z MEMBER

I'd be willing to prepare a PR, if this is still actual. Today I needed the *AllClose methods for my tests, I think it would be great to have these methods exposed.

I think I have an idea on how to proceed, but maybe I am underestimating the required amount of work.

Numpy for example has the np.allclose and np.testing.assert_allclose functions. Should xarray also have a xr.allclose function or are we happy with a xr.testing.assert_allclose alone? Also, the current xarray implementation has a different function for variables, datasets and coordinates: could these be merged in a generic assert_allclose which takes decisions on what to do based on the input type?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   132536288