issue_comments

Table actions

3 rows where issue = 1315607023 and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • headtr1ck · 3 ✖

issue 1

  • xarray 2022.6.0 doesn't work well with numpy 1.20 · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1215278493 https://github.com/pydata/xarray/issues/6818#issuecomment-1215278493 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85Ib62d headtr1ck 43316012 2022-08-15T16:18:10Z 2022-08-15T16:18:10Z COLLABORATOR

Thanks for the quick fix. Is there a plan to have a quick patch release (e.g., 2022.6.1)?

I think the devs are still too busy to publish more releases. Now it is already time for a 2022.8.0 release :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023
1193154771 https://github.com/pydata/xarray/issues/6818#issuecomment-1193154771 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85HHhjT headtr1ck 43316012 2022-07-23T16:53:47Z 2022-07-23T16:55:17Z COLLABORATOR

It seems that in 1.20 they started introducing typing but _SupportsDType[np.dtype] was not a generic yet.

Not really the fault of numpy, we are using a not-public interface.

So either we do a version check for 1.20, or we create our own SupportsDType (I assume a Protocol?)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023
1193103107 https://github.com/pydata/xarray/issues/6818#issuecomment-1193103107 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85HHU8D headtr1ck 43316012 2022-07-23T10:33:31Z 2022-07-23T14:39:36Z COLLABORATOR

Thanks for the report. I have to admit, that when I implemented the problematic part I also only tested numpy 1.19 and >1.21... (same with CI)

It seems that in 1.20 they used a different approach.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);