issue_comments

Table actions

8 rows where issue = 1315607023 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • xarray 2022.6.0 doesn't work well with numpy 1.20 · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1255550548 https://github.com/pydata/xarray/issues/6818#issuecomment-1255550548 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85K1i5U rabernat 1197350 2022-09-22T21:09:15Z 2022-09-22T21:09:15Z MEMBER

I just hit this same bug with numpy 1.23.3. Installing xarray from github main branch fixed it.

I think we really need to release soon (#7069).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023
1215309015 https://github.com/pydata/xarray/issues/6818#issuecomment-1215309015 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85IcCTX dcherian 2448579 2022-08-15T16:30:28Z 2022-08-15T16:30:38Z MEMBER

Yeah unfortunately there are still a number of unfixed regressions

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023
1215278493 https://github.com/pydata/xarray/issues/6818#issuecomment-1215278493 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85Ib62d headtr1ck 43316012 2022-08-15T16:18:10Z 2022-08-15T16:18:10Z COLLABORATOR

Thanks for the quick fix. Is there a plan to have a quick patch release (e.g., 2022.6.1)?

I think the devs are still too busy to publish more releases. Now it is already time for a 2022.8.0 release :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023
1208303132 https://github.com/pydata/xarray/issues/6818#issuecomment-1208303132 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85IBT4c seisman 3974108 2022-08-08T15:52:09Z 2022-08-08T15:52:09Z NONE

Thanks for the quick fix. Is there a plan to have a quick patch release (e.g., 2022.6.1)?

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023
1193164757 https://github.com/pydata/xarray/issues/6818#issuecomment-1193164757 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85HHj_V TomNicholas 35968931 2022-07-23T18:01:14Z 2022-07-23T18:01:14Z MEMBER

Right okay, thanks for the explanation @headtr1ck .

So either we do a version check for 1.20, or we create our own SupportsDType (I assume a Protocol?)

If we are still using a non-public interface, then we can't guarantee that it won't break again in numpy version 1.22 etc. So if that's the case perhaps we should try to make a sustainable solution. Otherwise I think special-casing one version is okay.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023
1193154771 https://github.com/pydata/xarray/issues/6818#issuecomment-1193154771 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85HHhjT headtr1ck 43316012 2022-07-23T16:53:47Z 2022-07-23T16:55:17Z COLLABORATOR

It seems that in 1.20 they started introducing typing but _SupportsDType[np.dtype] was not a generic yet.

Not really the fault of numpy, we are using a not-public interface.

So either we do a version check for 1.20, or we create our own SupportsDType (I assume a Protocol?)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023
1193153124 https://github.com/pydata/xarray/issues/6818#issuecomment-1193153124 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85HHhJk TomNicholas 35968931 2022-07-23T16:42:28Z 2022-07-23T16:42:28Z MEMBER

What changed in numpy such that only one version is incompatible with our new release? Seems quite odd to have something break for one version, then work again for the next version.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023
1193103107 https://github.com/pydata/xarray/issues/6818#issuecomment-1193103107 https://api.github.com/repos/pydata/xarray/issues/6818 IC_kwDOAMm_X85HHU8D headtr1ck 43316012 2022-07-23T10:33:31Z 2022-07-23T14:39:36Z COLLABORATOR

Thanks for the report. I have to admit, that when I implemented the problematic part I also only tested numpy 1.19 and >1.21... (same with CI)

It seems that in 1.20 they used a different approach.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray 2022.6.0 doesn't work well with numpy 1.20 1315607023

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);