issue_comments: 1193164757

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6818#issuecomment-1193164757 https://api.github.com/repos/pydata/xarray/issues/6818 1193164757 IC_kwDOAMm_X85HHj_V 35968931 2022-07-23T18:01:14Z 2022-07-23T18:01:14Z MEMBER

Right okay, thanks for the explanation @headtr1ck .

So either we do a version check for 1.20, or we create our own SupportsDType (I assume a Protocol?)

If we are still using a non-public interface, then we can't guarantee that it won't break again in numpy version 1.22 etc. So if that's the case perhaps we should try to make a sustainable solution. Otherwise I think special-casing one version is okay.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1315607023