issue_comments

Table actions

12 rows where issue = 130743212 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Allow empty result of numerical operations between DataArrays · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
184526596 https://github.com/pydata/xarray/pull/741#issuecomment-184526596 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE4NDUyNjU5Ng== max-sixty 5635139 2016-02-16T05:22:24Z 2016-02-16T05:22:24Z MEMBER

Cheers!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
184521334 https://github.com/pydata/xarray/pull/741#issuecomment-184521334 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE4NDUyMTMzNA== shoyer 1217238 2016-02-16T05:01:07Z 2016-02-16T05:01:07Z MEMBER

I'm probably going to call this an "enhancement" rather than a bug fix, but otherwise this looks good... I'll fix up the what's new page shortly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
184517662 https://github.com/pydata/xarray/pull/741#issuecomment-184517662 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE4NDUxNzY2Mg== shoyer 1217238 2016-02-16T04:52:55Z 2016-02-16T04:52:55Z MEMBER

OK, going to merge this...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
184485089 https://github.com/pydata/xarray/pull/741#issuecomment-184485089 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE4NDQ4NTA4OQ== shoyer 1217238 2016-02-16T02:37:37Z 2016-02-16T02:37:37Z MEMBER

Still thinking about the fillna behavior... I agree, it's weird that ds.fillna({'missing_variable': 0}) works without raising an error.

I would say this is consistent with in-place arithmetic on Datasets (i.e., left alignment of variable names), but we actually don't allow that with different variables currently... probably because I wanted to avoid this headache :). I think I'll add a special case in to ensure that we raise an error if there are unexpected variables in the fillna argument.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
184010463 https://github.com/pydata/xarray/pull/741#issuecomment-184010463 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE4NDAxMDQ2Mw== max-sixty 5635139 2016-02-15T00:11:55Z 2016-02-15T05:31:29Z MEMBER

This is my final PR of the recent bunch that's ready to go @shoyer 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
181720858 https://github.com/pydata/xarray/pull/741#issuecomment-181720858 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE4MTcyMDg1OA== max-sixty 5635139 2016-02-09T05:49:22Z 2016-02-09T05:49:22Z MEMBER

@shoyer I think this is a decent balance: - Allow empty dimensions - But raise if non-existent dimensions are supplied

I think the code and tests now reflect that. Let me know your thoughts / comments

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
180223621 https://github.com/pydata/xarray/pull/741#issuecomment-180223621 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE4MDIyMzYyMQ== max-sixty 5635139 2016-02-05T06:38:04Z 2016-02-05T06:38:04Z MEMBER

Super - those are now updated @shoyer 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
180156107 https://github.com/pydata/xarray/pull/741#issuecomment-180156107 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE4MDE1NjEwNw== shoyer 1217238 2016-02-05T02:04:40Z 2016-02-05T02:04:40Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
178906345 https://github.com/pydata/xarray/pull/741#issuecomment-178906345 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE3ODkwNjM0NQ== spencerahill 6200806 2016-02-03T00:24:04Z 2016-02-03T00:24:04Z CONTRIBUTOR

@shoyer thanks! Good to know.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
178872178 https://github.com/pydata/xarray/pull/741#issuecomment-178872178 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE3ODg3MjE3OA== shoyer 1217238 2016-02-02T22:48:01Z 2016-02-02T22:48:01Z MEMBER

Version.py gets created when you install xarray, e.g., when you run pip install -e . after running git clone.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
178729433 https://github.com/pydata/xarray/pull/741#issuecomment-178729433 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE3ODcyOTQzMw== spencerahill 6200806 2016-02-02T18:11:25Z 2016-02-02T18:12:04Z CONTRIBUTOR

@MaximilianR FWIW I also had problems with .version recently when I cloned from the main repo...ended up having to copy version.py from another xarray install. Maybe has something to do with .gitignore? xarray/version.py is included there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212
178683833 https://github.com/pydata/xarray/pull/741#issuecomment-178683833 https://api.github.com/repos/pydata/xarray/issues/741 MDEyOklzc3VlQ29tbWVudDE3ODY4MzgzMw== max-sixty 5635139 2016-02-02T16:51:33Z 2016-02-02T16:51:33Z MEMBER

Not sure if I'm doing something foolish - I had some issues running the tests on my machine because of the from .version import version as __version__. Let me know if there's a quick fix beyond me commenting that line out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty result of numerical operations between DataArrays 130743212

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);