issue_comments: 184485089

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/741#issuecomment-184485089 https://api.github.com/repos/pydata/xarray/issues/741 184485089 MDEyOklzc3VlQ29tbWVudDE4NDQ4NTA4OQ== 1217238 2016-02-16T02:37:37Z 2016-02-16T02:37:37Z MEMBER

Still thinking about the fillna behavior... I agree, it's weird that ds.fillna({'missing_variable': 0}) works without raising an error.

I would say this is consistent with in-place arithmetic on Datasets (i.e., left alignment of variable names), but we actually don't allow that with different variables currently... probably because I wanted to avoid this headache :). I think I'll add a special case in to ensure that we raise an error if there are unexpected variables in the fillna argument.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   130743212