issue_comments

Table actions

7 rows where issue = 1306903264 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Pull xarray's nbytes from nbytes attribute on arrays · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1192103529 https://github.com/pydata/xarray/pull/6797#issuecomment-1192103529 https://api.github.com/repos/pydata/xarray/issues/6797 IC_kwDOAMm_X85HDg5p dcherian 2448579 2022-07-22T02:03:43Z 2022-07-22T02:03:43Z MEMBER

Thanks @maxrjones I added a sparse variable test that fails on main.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pull xarray's nbytes from nbytes attribute on arrays 1306903264
1189861071 https://github.com/pydata/xarray/pull/6797#issuecomment-1189861071 https://api.github.com/repos/pydata/xarray/issues/6797 IC_kwDOAMm_X85G69bP TomNicholas 35968931 2022-07-20T05:57:58Z 2022-07-20T05:57:58Z MEMBER

Great first contribution @maxrjones ! #6804 should auto-merge in a sec so you can then fetch and merge in main to write your tests :smile: 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pull xarray's nbytes from nbytes attribute on arrays 1306903264
1189527359 https://github.com/pydata/xarray/pull/6797#issuecomment-1189527359 https://api.github.com/repos/pydata/xarray/issues/6797 IC_kwDOAMm_X85G5r8_ dcherian 2448579 2022-07-19T20:37:09Z 2022-07-19T20:37:09Z MEMBER

Ah great idea!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pull xarray's nbytes from nbytes attribute on arrays 1306903264
1189473091 https://github.com/pydata/xarray/pull/6797#issuecomment-1189473091 https://api.github.com/repos/pydata/xarray/issues/6797 IC_kwDOAMm_X85G5etD maxrjones 14077947 2022-07-19T19:31:31Z 2022-07-19T19:31:31Z CONTRIBUTOR

Thanks @maxrjones can you push any WIP tests you might have for this?

If it's alright I will wait for https://github.com/pydata/xarray/pull/6804 to be merged first because that will greatly simplify testing the changes. After that PR, the following could be added to xarray/tests/test_array_api.py to test both cases:

def test_properties(arrays) -> None: np_arr, xp_arr = arrays assert np_arr.nbytes == 48 assert xp_arr.nbytes == 48

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pull xarray's nbytes from nbytes attribute on arrays 1306903264
1189154297 https://github.com/pydata/xarray/pull/6797#issuecomment-1189154297 https://api.github.com/repos/pydata/xarray/issues/6797 IC_kwDOAMm_X85G4Q35 dcherian 2448579 2022-07-19T14:52:11Z 2022-07-19T14:52:11Z MEMBER

Thanks @maxrjones can you push any WIP tests you might have for this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pull xarray's nbytes from nbytes attribute on arrays 1306903264
1186293504 https://github.com/pydata/xarray/pull/6797#issuecomment-1186293504 https://api.github.com/repos/pydata/xarray/issues/6797 IC_kwDOAMm_X85GtWcA dcherian 2448579 2022-07-16T21:09:23Z 2022-07-16T21:09:23Z MEMBER

I should add a docstring as suggested

This would be great!

Adding docstrings for the other properties would be a great (separate) PR!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pull xarray's nbytes from nbytes attribute on arrays 1306903264
1186293138 https://github.com/pydata/xarray/pull/6797#issuecomment-1186293138 https://api.github.com/repos/pydata/xarray/issues/6797 IC_kwDOAMm_X85GtWWS maxrjones 14077947 2022-07-16T21:08:11Z 2022-07-16T21:08:11Z CONTRIBUTOR

Please let me know if I should add a docstring as suggested in https://github.com/pydata/xarray/issues/6565#issuecomment-1115545322. I didn't yet because most of the properties do not have docstrings.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pull xarray's nbytes from nbytes attribute on arrays 1306903264

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);