home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1189473091

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6797#issuecomment-1189473091 https://api.github.com/repos/pydata/xarray/issues/6797 1189473091 IC_kwDOAMm_X85G5etD 14077947 2022-07-19T19:31:31Z 2022-07-19T19:31:31Z CONTRIBUTOR

Thanks @maxrjones can you push any WIP tests you might have for this?

If it's alright I will wait for https://github.com/pydata/xarray/pull/6804 to be merged first because that will greatly simplify testing the changes. After that PR, the following could be added to xarray/tests/test_array_api.py to test both cases:

def test_properties(arrays) -> None: np_arr, xp_arr = arrays assert np_arr.nbytes == 48 assert xp_arr.nbytes == 48

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1306903264
Powered by Datasette · Queries took 0.664ms · About: xarray-datasette