issue_comments

Table actions

2 rows where issue = 128735308 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Replacing coord with coord of same name results in NaNs · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
174853158 https://github.com/pydata/xarray/issues/725#issuecomment-174853158 https://api.github.com/repos/pydata/xarray/issues/725 MDEyOklzc3VlQ29tbWVudDE3NDg1MzE1OA== shoyer 1217238 2016-01-26T06:30:16Z 2016-02-09T01:33:56Z MEMBER

Indeed, this is definitely a regression. Thanks for the report!

Somehow this does work properly for modifying coordinates on Dataset objects, though:

``` In [9]: ds = arr.to_dataset(name='foo')

In [10]: ds Out[10]: <xarray.Dataset> Dimensions: (abc: 3) Coordinates: * abc (abc) int64 0 1 2 Data variables: foo (abc) int64 0 1 2

In [11]: ds['abc'] = new_coord

In [12]: ds Out[12]: <xarray.Dataset> Dimensions: (abc: 3) Coordinates: * abc (abc) int64 1 2 3 Data variables: foo (abc) int64 0 1 2 ```

The logic here is mostly in here: https://github.com/pydata/xarray/blob/v0.7.0/xarray/core/merge.py

There's clearly something missing in the DataArray path (which goes through merge_dataarray_coords)... possibly we need to be using the overwrite_vars argument?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replacing coord with coord of same name results in NaNs 128735308
175174311 https://github.com/pydata/xarray/issues/725#issuecomment-175174311 https://api.github.com/repos/pydata/xarray/issues/725 MDEyOklzc3VlQ29tbWVudDE3NTE3NDMxMQ== spencerahill 6200806 2016-01-26T18:50:11Z 2016-01-26T18:50:11Z CONTRIBUTOR

Thanks, to_dataset is a good workaround.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replacing coord with coord of same name results in NaNs 128735308

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);