issue_comments: 174853158
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/725#issuecomment-174853158 | https://api.github.com/repos/pydata/xarray/issues/725 | 174853158 | MDEyOklzc3VlQ29tbWVudDE3NDg1MzE1OA== | 1217238 | 2016-01-26T06:30:16Z | 2016-02-09T01:33:56Z | MEMBER | Indeed, this is definitely a regression. Thanks for the report! Somehow this does work properly for modifying coordinates on ``` In [9]: ds = arr.to_dataset(name='foo') In [10]: ds Out[10]: <xarray.Dataset> Dimensions: (abc: 3) Coordinates: * abc (abc) int64 0 1 2 Data variables: foo (abc) int64 0 1 2 In [11]: ds['abc'] = new_coord In [12]: ds Out[12]: <xarray.Dataset> Dimensions: (abc: 3) Coordinates: * abc (abc) int64 1 2 3 Data variables: foo (abc) int64 0 1 2 ``` The logic here is mostly in here: https://github.com/pydata/xarray/blob/v0.7.0/xarray/core/merge.py There's clearly something missing in the DataArray path (which goes through merge_dataarray_coords)... possibly we need to be using the overwrite_vars argument? |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
128735308 |