issue_comments

Table actions

5 rows where issue = 1248463174 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Improved DataArray typing · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1139758396 https://github.com/pydata/xarray/pull/6637#issuecomment-1139758396 https://api.github.com/repos/pydata/xarray/issues/6637 IC_kwDOAMm_X85D71U8 max-sixty 5635139 2022-05-27T16:10:39Z 2022-05-27T16:10:39Z MEMBER

We could start setting up a lint for every function in tests being type checked (i.e. having -> None). I converted most of the files a while ago, @headtr1ck has done some of the really heavy duty ones. If we can lock that in, it would be a huge win for ensuring future tests also test our types.

There is a mypy lint for it IIRC, and I think it can be enabled on a subset of files.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved DataArray typing 1248463174
1139752123 https://github.com/pydata/xarray/pull/6637#issuecomment-1139752123 https://api.github.com/repos/pydata/xarray/issues/6637 IC_kwDOAMm_X85D7zy7 Illviljan 14371165 2022-05-27T16:03:18Z 2022-05-27T16:03:18Z MEMBER

Thanks, @headtr1ck!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved DataArray typing 1248463174
1138948647 https://github.com/pydata/xarray/pull/6637#issuecomment-1138948647 https://api.github.com/repos/pydata/xarray/issues/6637 IC_kwDOAMm_X85D4von max-sixty 5635139 2022-05-26T19:48:48Z 2022-05-26T19:48:48Z MEMBER

This is huge, thanks @headtr1ck !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved DataArray typing 1248463174
1138542724 https://github.com/pydata/xarray/pull/6637#issuecomment-1138542724 https://api.github.com/repos/pydata/xarray/issues/6637 IC_kwDOAMm_X85D3MiE headtr1ck 43316012 2022-05-26T12:50:32Z 2022-05-26T12:50:32Z COLLABORATOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved DataArray typing 1248463174
1137751446 https://github.com/pydata/xarray/pull/6637#issuecomment-1137751446 https://api.github.com/repos/pydata/xarray/issues/6637 IC_kwDOAMm_X85D0LWW TomNicholas 35968931 2022-05-25T19:09:32Z 2022-05-25T19:09:32Z MEMBER

This is really great, thank you for all this work @headtr1ck !

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved DataArray typing 1248463174

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);