home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1139758396

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6637#issuecomment-1139758396 https://api.github.com/repos/pydata/xarray/issues/6637 1139758396 IC_kwDOAMm_X85D71U8 5635139 2022-05-27T16:10:39Z 2022-05-27T16:10:39Z MEMBER

We could start setting up a lint for every function in tests being type checked (i.e. having -> None). I converted most of the files a while ago, @headtr1ck has done some of the really heavy duty ones. If we can lock that in, it would be a huge win for ensuring future tests also test our types.

There is a mypy lint for it IIRC, and I think it can be enabled on a subset of files.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1248463174
Powered by Datasette · Queries took 1.658ms · About: xarray-datasette