issue_comments

Table actions

5 rows where issue = 1236356209 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Typing for open_dataset/array/mfdataset and to_netcdf/zarr · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1129240746 https://github.com/pydata/xarray/pull/6612#issuecomment-1129240746 https://api.github.com/repos/pydata/xarray/issues/6612 IC_kwDOAMm_X85DTtiq max-sixty 5635139 2022-05-17T19:31:55Z 2022-05-17T19:31:55Z MEMBER

Puh, 1k LOC diff, that was quite the rabbit hole...

Yes!

Re the concat_dim — it looks quite reasonable, though I'm not the expert. I would vote to merge before we get conflicts as I recognize it must have taken a lot of work to get here. I will also add a label and ask someone to have a look at our next dev meeting, though I suspect through time we'll find any improvements through bug reports & tests.

Thank you very much @headtr1ck !

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for open_dataset/array/mfdataset and to_netcdf/zarr 1236356209
1129190826 https://github.com/pydata/xarray/pull/6612#issuecomment-1129190826 https://api.github.com/repos/pydata/xarray/issues/6612 IC_kwDOAMm_X85DThWq headtr1ck 43316012 2022-05-17T18:32:27Z 2022-05-17T18:32:27Z COLLABORATOR

Puh, 1k LOC diff, that was quite the rabbit hole...

There is still one open point: The concat_dim arg is not clear to me what the type is actually allowed. The Index is only there because the docstring mentions it, in the code it is not checked so this might be actually wrong. Someone with a better understanding of this part should check this type!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for open_dataset/array/mfdataset and to_netcdf/zarr 1236356209
1128011992 https://github.com/pydata/xarray/pull/6612#issuecomment-1128011992 https://api.github.com/repos/pydata/xarray/issues/6612 IC_kwDOAMm_X85DPBjY headtr1ck 43316012 2022-05-16T18:42:43Z 2022-05-16T18:42:43Z COLLABORATOR

Whoops, some typing has lead to a bunch of type errors. I'll have to fix that some other day :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for open_dataset/array/mfdataset and to_netcdf/zarr 1236356209
1127533729 https://github.com/pydata/xarray/pull/6612#issuecomment-1127533729 https://api.github.com/repos/pydata/xarray/issues/6612 IC_kwDOAMm_X85DNMyh headtr1ck 43316012 2022-05-16T11:08:02Z 2022-05-16T11:08:02Z COLLABORATOR

I think merging main may fix the benchmark errors. (If you enable permissions for maintainers to modify the PR then GH offers a button to do this, FWIW)

It shows as enabled for me?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for open_dataset/array/mfdataset and to_netcdf/zarr 1236356209
1127088163 https://github.com/pydata/xarray/pull/6612#issuecomment-1127088163 https://api.github.com/repos/pydata/xarray/issues/6612 IC_kwDOAMm_X85DLgAj max-sixty 5635139 2022-05-15T23:40:24Z 2022-05-15T23:40:24Z MEMBER

I think merging main may fix the benchmark errors. (If you enable permissions for maintainers to modify the PR then GH offers a button to do this, FWIW)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for open_dataset/array/mfdataset and to_netcdf/zarr 1236356209

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);