issue_comments: 1129240746

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6612#issuecomment-1129240746 https://api.github.com/repos/pydata/xarray/issues/6612 1129240746 IC_kwDOAMm_X85DTtiq 5635139 2022-05-17T19:31:55Z 2022-05-17T19:31:55Z MEMBER

Puh, 1k LOC diff, that was quite the rabbit hole...

Yes!

Re the concat_dim — it looks quite reasonable, though I'm not the expert. I would vote to merge before we get conflicts as I recognize it must have taken a lot of work to get here. I will also add a label and ask someone to have a look at our next dev meeting, though I suspect through time we'll find any improvements through bug reports & tests.

Thank you very much @headtr1ck !

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1236356209