issue_comments

Table actions

4 rows where issue = 1222215528 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • sortby with ascending=False should create an index · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1114351090 https://github.com/pydata/xarray/issues/6555#issuecomment-1114351090 https://api.github.com/repos/pydata/xarray/issues/6555 IC_kwDOAMm_X85Ca6Xy headtr1ck 43316012 2022-05-01T22:17:40Z 2022-05-01T22:17:40Z COLLABORATOR

Ok, then I'm fine with the current state.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sortby with ascending=False should create an index 1222215528
1114343924 https://github.com/pydata/xarray/issues/6555#issuecomment-1114343924 https://api.github.com/repos/pydata/xarray/issues/6555 IC_kwDOAMm_X85Ca4n0 max-sixty 5635139 2022-05-01T21:48:34Z 2022-05-01T21:48:34Z MEMBER

I guess my understanding of indexes was: "no index" == "default index ~range(0,n)".

Yeah — that is the case in pandas. But in xarray, we can have dims without indexes, so adding one is making a change...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sortby with ascending=False should create an index 1222215528
1114303627 https://github.com/pydata/xarray/issues/6555#issuecomment-1114303627 https://api.github.com/repos/pydata/xarray/issues/6555 IC_kwDOAMm_X85CauyL headtr1ck 43316012 2022-05-01T18:23:47Z 2022-05-01T18:23:47Z COLLABORATOR

I guess my understanding of indexes was: "no index" == "default index ~range(0,n)".

Therefore, if no index exists and ascending=True, no index in the output is correct.

But then again I agree that it is easy for users to add an index.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sortby with ascending=False should create an index 1222215528
1114302353 https://github.com/pydata/xarray/issues/6555#issuecomment-1114302353 https://api.github.com/repos/pydata/xarray/issues/6555 IC_kwDOAMm_X85CaueR max-sixty 5635139 2022-05-01T18:16:30Z 2022-05-01T18:16:30Z MEMBER

Would we then have a different schema for different values of ascending?

If that's correct I would vote against this; I empathize with the confusion, but then the caller can add an index, and generally we don't want different values of arguments to create different schema without a very obvious and explicit connection between them.

Tbh even if the proposal is to add the index for any value of ascending, I'd be marginally against; it's not what I'd expect as a user. But open-minded on this.

(Thanks for adding the issue @headtr1ck , hope this comes across as constructive)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sortby with ascending=False should create an index 1222215528

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);