home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1114302353

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6555#issuecomment-1114302353 https://api.github.com/repos/pydata/xarray/issues/6555 1114302353 IC_kwDOAMm_X85CaueR 5635139 2022-05-01T18:16:30Z 2022-05-01T18:16:30Z MEMBER

Would we then have a different schema for different values of ascending?

If that's correct I would vote against this; I empathize with the confusion, but then the caller can add an index, and generally we don't want different values of arguments to create different schema without a very obvious and explicit connection between them.

Tbh even if the proposal is to add the index for any value of ascending, I'd be marginally against; it's not what I'd expect as a user. But open-minded on this.

(Thanks for adding the issue @headtr1ck , hope this comes across as constructive)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1222215528
Powered by Datasette · Queries took 0.492ms · About: xarray-datasette