issue_comments

Table actions

3 rows where issue = 1221848774 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • polyval: Use Horner's algorithm + support chunked inputs · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1118973967 https://github.com/pydata/xarray/pull/6548#issuecomment-1118973967 https://api.github.com/repos/pydata/xarray/issues/6548 IC_kwDOAMm_X85CsjAP max-sixty 5635139 2022-05-05T19:33:53Z 2022-05-05T19:33:53Z MEMBER

Thanks @headtr1ck !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   polyval: Use Horner's algorithm + support chunked inputs 1221848774
1114366068 https://github.com/pydata/xarray/pull/6548#issuecomment-1114366068 https://api.github.com/repos/pydata/xarray/issues/6548 IC_kwDOAMm_X85Ca-B0 max-sixty 5635139 2022-05-01T23:24:56Z 2022-05-01T23:24:56Z MEMBER

Benchmark did not succeed since the inputs are not compatible with the old algorith... Do we change it such that it is compatible?

If you're confident this is faster and it's not a trivial amount of work to adjust them, I would leave it...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   polyval: Use Horner's algorithm + support chunked inputs 1221848774
1114054278 https://github.com/pydata/xarray/pull/6548#issuecomment-1114054278 https://api.github.com/repos/pydata/xarray/issues/6548 IC_kwDOAMm_X85CZx6G max-sixty 5635139 2022-04-30T21:07:10Z 2022-04-30T21:07:10Z MEMBER

This looks like excellent code @headtr1ck , especially so for a first PR. Welcome!

so I used a "hack" of adding an 0-valued DataArray/Dataset.

I think it's fine to do the hack and reference that issue; we can clean it up then (though if others have ideas then great).

I had to add a copy(deep=True) since the broadcast returned a read-only DataArray. Any better ideas?

IIRC we generally leave this up to the caller (and generally discourage mutation).

Someone who knows better should review the algo & opine on the datetime issue; I agree I'm not sure whether we need to support them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   polyval: Use Horner's algorithm + support chunked inputs 1221848774

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);