issue_comments: 1114054278

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6548#issuecomment-1114054278 https://api.github.com/repos/pydata/xarray/issues/6548 1114054278 IC_kwDOAMm_X85CZx6G 5635139 2022-04-30T21:07:10Z 2022-04-30T21:07:10Z MEMBER

This looks like excellent code @headtr1ck , especially so for a first PR. Welcome!

so I used a "hack" of adding an 0-valued DataArray/Dataset.

I think it's fine to do the hack and reference that issue; we can clean it up then (though if others have ideas then great).

I had to add a copy(deep=True) since the broadcast returned a read-only DataArray. Any better ideas?

IIRC we generally leave this up to the caller (and generally discourage mutation).

Someone who knows better should review the algo & opine on the datetime issue; I agree I'm not sure whether we need to support them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1221848774