issue_comments

Table actions

2 rows where issue = 1171069302 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • #6367 Fix for time units checking could produce "unhashable type" error · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1072813115 https://github.com/pydata/xarray/pull/6368#issuecomment-1072813115 https://api.github.com/repos/pydata/xarray/issues/6368 IC_kwDOAMm_X84_8dQ7 spencerkclark 6628425 2022-03-18T21:21:20Z 2022-03-18T21:21:20Z MEMBER

Thanks again @okhoma -- welcome to xarray!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   #6367 Fix for time units checking could produce "unhashable type" error 1171069302
1072386789 https://github.com/pydata/xarray/pull/6368#issuecomment-1072386789 https://api.github.com/repos/pydata/xarray/issues/6368 IC_kwDOAMm_X84_61Ll okhoma 212077 2022-03-18T12:59:55Z 2022-03-18T12:59:55Z CONTRIBUTOR

Thanks @okhoma! This solution looks good. Could you add a basic test to test_conventions.py? I think constructing an example Variable object with an array "units" attribute and then calling conventions.decode_cf_variable on it would suffice.

Added test 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   #6367 Fix for time units checking could produce "unhashable type" error 1171069302

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);