home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1072386789

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6368#issuecomment-1072386789 https://api.github.com/repos/pydata/xarray/issues/6368 1072386789 IC_kwDOAMm_X84_61Ll 212077 2022-03-18T12:59:55Z 2022-03-18T12:59:55Z CONTRIBUTOR

Thanks @okhoma! This solution looks good. Could you add a basic test to test_conventions.py? I think constructing an example Variable object with an array "units" attribute and then calling conventions.decode_cf_variable on it would suffice.

Added test

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1171069302
Powered by Datasette · Queries took 0.585ms · About: xarray-datasette