issue_comments

Table actions

3 rows where issue = 112424213 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Remove all mutable arguments from functions · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
149673897 https://github.com/pydata/xarray/pull/633#issuecomment-149673897 https://api.github.com/repos/pydata/xarray/issues/633 MDEyOklzc3VlQ29tbWVudDE0OTY3Mzg5Nw== petercable 6645714 2015-10-20T19:19:17Z 2015-10-20T19:19:17Z CONTRIBUTOR

Done!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove all mutable arguments from functions 112424213
149670991 https://github.com/pydata/xarray/pull/633#issuecomment-149670991 https://api.github.com/repos/pydata/xarray/issues/633 MDEyOklzc3VlQ29tbWVudDE0OTY3MDk5MQ== shoyer 1217238 2015-10-20T19:08:27Z 2015-10-20T19:08:27Z MEMBER

Could you remove this change from the roundtrip methods in the tests? Those are simply using dictionary unpacking to pass on keyword arguments so they seem pretty safe to me, and this is a bit heavy on the added noise there.

Otherwise this looks good and I'll merge this in. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove all mutable arguments from functions 112424213
149657724 https://github.com/pydata/xarray/pull/633#issuecomment-149657724 https://api.github.com/repos/pydata/xarray/issues/633 MDEyOklzc3VlQ29tbWVudDE0OTY1NzcyNA== shoyer 1217238 2015-10-20T18:30:26Z 2015-10-20T18:30:26Z MEMBER

Yeah, this was mostly intentional. As long as I'm only writing pure functions, mutable default arguments are safe and a little more succinct.

That said, this is indeed a bit at odds with standard coding style for Python, so I'm OK with this change going forward.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove all mutable arguments from functions 112424213

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);