home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 149670991

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/633#issuecomment-149670991 https://api.github.com/repos/pydata/xarray/issues/633 149670991 MDEyOklzc3VlQ29tbWVudDE0OTY3MDk5MQ== 1217238 2015-10-20T19:08:27Z 2015-10-20T19:08:27Z MEMBER

Could you remove this change from the roundtrip methods in the tests? Those are simply using dictionary unpacking to pass on keyword arguments so they seem pretty safe to me, and this is a bit heavy on the added noise there.

Otherwise this looks good and I'll merge this in. Thanks!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  112424213
Powered by Datasette · Queries took 0.694ms · About: xarray-datasette