issue_comments

Table actions

5 rows where issue = 110806123 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 5 ✖

issue 1

  • numpy 1.10 compat fixes · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
147512768 https://github.com/pydata/xarray/pull/618#issuecomment-147512768 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzUxMjc2OA== shoyer 1217238 2015-10-12T20:35:46Z 2015-10-12T20:35:46Z MEMBER

OK, why don't we merge this, then I'll take a look at the remaining failing test? I think I can fix that by adjusting .travis.yml.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy 1.10 compat fixes 110806123
147281012 https://github.com/pydata/xarray/pull/618#issuecomment-147281012 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzI4MTAxMg== shoyer 1217238 2015-10-12T03:10:33Z 2015-10-12T03:10:33Z MEMBER

In any case, I was wrong about what had changed with NumPy 1.10. This appears to be inadvertent... (sigh).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy 1.10 compat fixes 110806123
147274729 https://github.com/pydata/xarray/pull/618#issuecomment-147274729 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzI3NDcyOQ== shoyer 1217238 2015-10-12T02:28:26Z 2015-10-12T02:28:26Z MEMBER

Hmm. Something seem to have broken/changed with NumPy 1.10:

``` In [1]: import numpy as np

In [2]: np.datetime64('NaT') == np.datetime64('NaT') Out[2]: True

In [3]: np.datetime64('NaT') == np.datetime64('NaT', 'us') /Users/shoyer/miniconda/envs/tmp-np1.10/bin/ipython:1: DeprecationWarning: elementwise == comparison failed; this will raise an error in the future. #!/bin/bash /Users/shoyer/miniconda/envs/tmp-np1.10/bin/python.app Out[3]: False ```

I'm not quite sure what's going on there, so I'll file an issue in the NumPy repo.

In the meantime, we may want to update our test to coerce to datetime64[ns] first.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy 1.10 compat fixes 110806123
147129634 https://github.com/pydata/xarray/pull/618#issuecomment-147129634 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzEyOTYzNA== shoyer 1217238 2015-10-10T22:07:32Z 2015-10-10T22:07:32Z MEMBER

The "numpy equal will not check object identity in the future" warning is really annoying. The problem is that we put NaN in object arrays to indicate missing values (like pandas). Equals on object arrays currently applies the elementwise check x is y or x == y, which of course is different from x == y for NaN.

Of course, we have our own check for NaN which means this warning isn't relevant for us. If the warnings have gotten more verbose, I'll take another look. If you're interested in trying out some fixes, this is where they originate from: https://github.com/xray/xray/blob/a2fa27004f6cac476a3dbec2fa0774716f05f198/xray/core/ops.py#L183

I'll futz with the Travis-CI settings and see if I can get it installing happily again.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy 1.10 compat fixes 110806123
147128970 https://github.com/pydata/xarray/pull/618#issuecomment-147128970 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzEyODk3MA== shoyer 1217238 2015-10-10T22:01:26Z 2015-10-10T22:01:26Z MEMBER

NumPy fixed comparison operations with NaT in 1.10. Previously, NaT == NaT was true. Now it's false, like how NaN works.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy 1.10 compat fixes 110806123

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);