issue_comments: 147129634

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/618#issuecomment-147129634 https://api.github.com/repos/pydata/xarray/issues/618 147129634 MDEyOklzc3VlQ29tbWVudDE0NzEyOTYzNA== 1217238 2015-10-10T22:07:32Z 2015-10-10T22:07:32Z MEMBER

The "numpy equal will not check object identity in the future" warning is really annoying. The problem is that we put NaN in object arrays to indicate missing values (like pandas). Equals on object arrays currently applies the elementwise check x is y or x == y, which of course is different from x == y for NaN.

Of course, we have our own check for NaN which means this warning isn't relevant for us. If the warnings have gotten more verbose, I'll take another look. If you're interested in trying out some fixes, this is where they originate from: https://github.com/xray/xray/blob/a2fa27004f6cac476a3dbec2fa0774716f05f198/xray/core/ops.py#L183

I'll futz with the Travis-CI settings and see if I can get it installing happily again.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   110806123