issue_comments

Table actions

4 rows where issue = 1091822549 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • TST: check datetime converter is Matplotlibs · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1004258711 https://github.com/pydata/xarray/pull/6128#issuecomment-1004258711 https://api.github.com/repos/pydata/xarray/issues/6128 IC_kwDOAMm_X84728WX Illviljan 14371165 2022-01-03T17:59:21Z 2022-01-03T17:59:21Z MEMBER

Sure.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TST: check datetime converter is Matplotlibs 1091822549
1004257077 https://github.com/pydata/xarray/pull/6128#issuecomment-1004257077 https://api.github.com/repos/pydata/xarray/issues/6128 IC_kwDOAMm_X8472781 dcherian 2448579 2022-01-03T17:55:42Z 2022-01-03T17:55:42Z MEMBER

Shall we merge and then tweak it in #6109

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TST: check datetime converter is Matplotlibs 1091822549
1003582857 https://github.com/pydata/xarray/pull/6128#issuecomment-1003582857 https://api.github.com/repos/pydata/xarray/issues/6128 IC_kwDOAMm_X8470XWJ jklymak 1562854 2022-01-01T16:45:01Z 2022-01-01T16:45:01Z CONTRIBUTOR

The point of my original concern was the case where the automatic import should not nbe happening. I think that the new version of my test should work with the revert of #6109.

I agree that the import logic is a bit of a pain. OTOH I'm not sure how to make it better. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TST: check datetime converter is Matplotlibs 1091822549
1003572765 https://github.com/pydata/xarray/pull/6128#issuecomment-1003572765 https://api.github.com/repos/pydata/xarray/issues/6128 IC_kwDOAMm_X8470U4d Illviljan 14371165 2022-01-01T15:16:41Z 2022-01-01T15:16:41Z MEMBER

This should require #6109 to pass.

I believe this doesn't error at the moment because the test simply doesn't trigger the import_matplotlib_pyplot path because * ax is used as input, so no need to import plt. * if ax is None with line plots, it will still just do a normal import anyway: https://github.com/pydata/xarray/blob/f75c3be583db377e1efe0fb90ece11e79bb4297e/xarray/plot/utils.py#L456-L458 The import registration seems to only happen with 2d plots: https://github.com/pydata/xarray/blob/f75c3be583db377e1efe0fb90ece11e79bb4297e/xarray/plot/plot.py#L1114

One reason why #5794 was nice, at least the importing was consistent.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TST: check datetime converter is Matplotlibs 1091822549

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);