issue_comments: 1003572765

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6128#issuecomment-1003572765 https://api.github.com/repos/pydata/xarray/issues/6128 1003572765 IC_kwDOAMm_X8470U4d 14371165 2022-01-01T15:16:41Z 2022-01-01T15:16:41Z MEMBER

This should require #6109 to pass.

I believe this doesn't error at the moment because the test simply doesn't trigger the import_matplotlib_pyplot path because * ax is used as input, so no need to import plt. * if ax is None with line plots, it will still just do a normal import anyway: https://github.com/pydata/xarray/blob/f75c3be583db377e1efe0fb90ece11e79bb4297e/xarray/plot/utils.py#L456-L458 The import registration seems to only happen with 2d plots: https://github.com/pydata/xarray/blob/f75c3be583db377e1efe0fb90ece11e79bb4297e/xarray/plot/plot.py#L1114

One reason why #5794 was nice, at least the importing was consistent.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1091822549