issue_comments

Table actions

4 rows where issue = 106886175 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Raise an error if DataArray name is not able to be written to netCDF. · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
141480082 https://github.com/pydata/xarray/pull/580#issuecomment-141480082 https://api.github.com/repos/pydata/xarray/issues/580 MDEyOklzc3VlQ29tbWVudDE0MTQ4MDA4Mg== shoyer 1217238 2015-09-18T15:15:39Z 2015-09-18T15:15:39Z MEMBER

Yep, looks good to me. Feel free to merge when you're ready.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise an error if DataArray name is not able to be written to netCDF. 106886175
141474949 https://github.com/pydata/xarray/pull/580#issuecomment-141474949 https://api.github.com/repos/pydata/xarray/issues/580 MDEyOklzc3VlQ29tbWVudDE0MTQ3NDk0OQ== jhamman 2443309 2015-09-18T14:53:51Z 2015-09-18T14:53:51Z MEMBER

Thanks, that fixed it. I wasn't aware we had other datastore tests in test_conventions.py. Now I know.

It looks like I've hit all your previous comments.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise an error if DataArray name is not able to be written to netCDF. 106886175
141350728 https://github.com/pydata/xarray/pull/580#issuecomment-141350728 https://api.github.com/repos/pydata/xarray/issues/580 MDEyOklzc3VlQ29tbWVudDE0MTM1MDcyOA== shoyer 1217238 2015-09-18T05:38:34Z 2015-09-18T05:38:34Z MEMBER

The failing test case is on a generic CFEncodedDataStore test, which actually doesn't use to_netcdf to roundtrip the data: https://github.com/xray/xray/blob/c13ee9875b31dceb505b4aead83272fbcbeef27e/xray/test/test_conventions.py#L541

I would simply special case that test on that object because it isn't relevant, e.g., on the TestCFEncodedDataStore object, add a method:

def test_invalid_dataarray_names_raise(self): pass

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise an error if DataArray name is not able to be written to netCDF. 106886175
141344086 https://github.com/pydata/xarray/pull/580#issuecomment-141344086 https://api.github.com/repos/pydata/xarray/issues/580 MDEyOklzc3VlQ29tbWVudDE0MTM0NDA4Ng== jhamman 2443309 2015-09-18T04:54:34Z 2015-09-18T04:54:34Z MEMBER

@shoyer - can you take a look at these failing tests and see if you can tell which backend is causing the failure? I'm a bit confused on why it isn't getting caught by my _validate_dataset_names function in to_netcdf.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise an error if DataArray name is not able to be written to netCDF. 106886175

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);