issue_comments: 141350728

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/580#issuecomment-141350728 https://api.github.com/repos/pydata/xarray/issues/580 141350728 MDEyOklzc3VlQ29tbWVudDE0MTM1MDcyOA== 1217238 2015-09-18T05:38:34Z 2015-09-18T05:38:34Z MEMBER

The failing test case is on a generic CFEncodedDataStore test, which actually doesn't use to_netcdf to roundtrip the data: https://github.com/xray/xray/blob/c13ee9875b31dceb505b4aead83272fbcbeef27e/xray/test/test_conventions.py#L541

I would simply special case that test on that object because it isn't relevant, e.g., on the TestCFEncodedDataStore object, add a method:

def test_invalid_dataarray_names_raise(self): pass

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   106886175