home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

1 row where issue = 1055867960 and user = 3698640 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • delgadom · 1 ✖

issue 1

  • interpolate_na, x and y arrays must have at least 2 entries, warning instead of raise ? · 1 ✖

author_association 1

  • CONTRIBUTOR 1
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1003460778 https://github.com/pydata/xarray/issues/5994#issuecomment-1003460778 https://api.github.com/repos/pydata/xarray/issues/5994 IC_kwDOAMm_X847z5iq delgadom 3698640 2021-12-31T22:36:04Z 2021-12-31T22:41:51Z CONTRIBUTOR

This looks like it could be a good improvement! Just flagging that in func_interpolate_na on main I see a different condition: python # fast track for no-nans and all-nans cases n_nans = nans.sum() if n_nans == 0 or n_nans == len(y): return y

Do you see the n_nans < 0 condition somewhere or is this just a typo? That condition also wouldn't make much sense.

Your point about using the shortcut for n_nans == len(y) - 1 seems right to me, and definitely doesn't seem worthy of an error when an all-NaN slice is silently skipped.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  interpolate_na, x and y arrays must have at least 2 entries, warning instead of raise ? 1055867960

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 728.252ms · About: xarray-datasette