issue_comments: 1003460778

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5994#issuecomment-1003460778 https://api.github.com/repos/pydata/xarray/issues/5994 1003460778 IC_kwDOAMm_X847z5iq 3698640 2021-12-31T22:36:04Z 2021-12-31T22:41:51Z CONTRIBUTOR

This looks like it could be a good improvement! Just flagging that in func_interpolate_na on main I see a different condition: python # fast track for no-nans and all-nans cases n_nans = nans.sum() if n_nans == 0 or n_nans == len(y): return y

Do you see the n_nans < 0 condition somewhere or is this just a typo? That condition also wouldn't make much sense.

Your point about using the shortcut for n_nans == len(y) - 1 seems right to me, and definitely doesn't seem worthy of an error when an all-NaN slice is silently skipped.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1055867960