issue_comments

Table actions

7 rows where issue = 1052753606 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 4

issue 1

  • Formatting data array as strings? · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1473820156 https://github.com/pydata/xarray/issues/5985#issuecomment-1473820156 https://api.github.com/repos/pydata/xarray/issues/5985 IC_kwDOAMm_X85X2LX8 headtr1ck 43316012 2023-03-17T13:09:02Z 2023-03-17T13:10:06Z COLLABORATOR

Found as an answer to a proposal PR: https://github.com/pydata/xarray/pull/7628#discussion_r1140211918

The solution is to use .str.format the other way around as you propose:

You can try das.str.format(da). Maybe you need to use {} instead of % in your format array.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Formatting data array as strings? 1052753606
1466374343 https://github.com/pydata/xarray/issues/5985#issuecomment-1466374343 https://api.github.com/repos/pydata/xarray/issues/5985 IC_kwDOAMm_X85XZxjH mathause 10194086 2023-03-13T15:32:45Z 2023-03-13T15:32:45Z MEMBER

I probably got this from a pandas issue/ pull request - but I can't remember where exactly - sorry...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Formatting data array as strings? 1052753606
1462537234 https://github.com/pydata/xarray/issues/5985#issuecomment-1462537234 https://api.github.com/repos/pydata/xarray/issues/5985 IC_kwDOAMm_X85XLIwS ahuang11 15331990 2023-03-09T18:08:10Z 2023-03-09T18:08:10Z CONTRIBUTOR

Thanks for following up! It's been a while so I don't remember; feel free to disregard what I said.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Formatting data array as strings? 1052753606
1462493521 https://github.com/pydata/xarray/issues/5985#issuecomment-1462493521 https://api.github.com/repos/pydata/xarray/issues/5985 IC_kwDOAMm_X85XK-FR TomNicholas 35968931 2023-03-09T17:47:58Z 2023-03-09T17:47:58Z MEMBER

Hi @alrho007 - thanks for your interest in contributing to xarray!

The code for the string accessor is in xarray/core/accessor_str.py. That's where you would need to make changes.

The idea would be to wrap xr.DataArray.str.mod in xr.DataArray.str.format.

@mathause could you expand on what you mean exactly? I'm new to this part of the codebase. There is already a .format method, are you talking about changing its behaviour?

xr.DataArray([0, 1, 2]).str would raise an error right since it's int type?

Also @ahuang11 this seems fine? Because the .str accessor doesn't actually perform a check that the passed data is a str type immediately?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Formatting data array as strings? 1052753606
1461552218 https://github.com/pydata/xarray/issues/5985#issuecomment-1461552218 https://api.github.com/repos/pydata/xarray/issues/5985 IC_kwDOAMm_X85XHYRa husainridwan 61923007 2023-03-09T08:27:23Z 2023-03-09T08:31:14Z NONE

Hi @TomNicholas , how do I contribute to this as an outreachy intern?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Formatting data array as strings? 1052753606
969794751 https://github.com/pydata/xarray/issues/5985#issuecomment-969794751 https://api.github.com/repos/pydata/xarray/issues/5985 IC_kwDOAMm_X845zeS_ ahuang11 15331990 2021-11-16T03:27:20Z 2021-11-16T03:27:20Z CONTRIBUTOR

Actually would xr.DataArray.str.format work? e.g. xr.DataArray([0, 1, 2]).str would raise an error right since it's int type?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Formatting data array as strings? 1052753606
968908702 https://github.com/pydata/xarray/issues/5985#issuecomment-968908702 https://api.github.com/repos/pydata/xarray/issues/5985 IC_kwDOAMm_X845wF-e mathause 10194086 2021-11-15T13:25:56Z 2021-11-15T13:25:56Z MEMBER

I think that sounds sensible. The idea would be to wrap xr.DataArray.str.__mod__ in xr.DataArray.str.format. Are you interested in providing a PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Formatting data array as strings? 1052753606

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);