issue_comments: 1462493521

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5985#issuecomment-1462493521 https://api.github.com/repos/pydata/xarray/issues/5985 1462493521 IC_kwDOAMm_X85XK-FR 35968931 2023-03-09T17:47:58Z 2023-03-09T17:47:58Z MEMBER

Hi @alrho007 - thanks for your interest in contributing to xarray!

The code for the string accessor is in xarray/core/accessor_str.py. That's where you would need to make changes.

The idea would be to wrap xr.DataArray.str.mod in xr.DataArray.str.format.

@mathause could you expand on what you mean exactly? I'm new to this part of the codebase. There is already a .format method, are you talking about changing its behaviour?

xr.DataArray([0, 1, 2]).str would raise an error right since it's int type?

Also @ahuang11 this seems fine? Because the .str accessor doesn't actually perform a check that the passed data is a str type immediately?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1052753606