issue_comments

Table actions

5 rows where issue = 1050367667 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Respect keep_attrs when using `Dataset.set_index` (#4955) · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
978040544 https://github.com/pydata/xarray/pull/5972#issuecomment-978040544 https://api.github.com/repos/pydata/xarray/issues/5972 IC_kwDOAMm_X846S7bg benbovy 4160723 2021-11-24T16:34:29Z 2021-11-24T16:34:29Z MEMBER

I think I added tests for attributes in #5692, but I need to check.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Respect keep_attrs when using `Dataset.set_index` (#4955) 1050367667
978011074 https://github.com/pydata/xarray/pull/5972#issuecomment-978011074 https://api.github.com/repos/pydata/xarray/issues/5972 IC_kwDOAMm_X846S0PC dcherian 2448579 2021-11-24T15:59:38Z 2021-11-24T15:59:38Z MEMBER

Shall we merge only the test then?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Respect keep_attrs when using `Dataset.set_index` (#4955) 1050367667
977743927 https://github.com/pydata/xarray/pull/5972#issuecomment-977743927 https://api.github.com/repos/pydata/xarray/issues/5972 IC_kwDOAMm_X846RzA3 benbovy 4160723 2021-11-24T10:31:11Z 2021-11-24T10:31:11Z MEMBER

Thanks for pinging me @mathause. And sorry @gcaria I didn't see #4955 and this PR until now.

Indeed, there's no need for a fix considering that in #5692 variable attributes are now propagated properly through set_index and other operations on indexes (see https://github.com/pydata/xarray/pull/5692/commits/0086e326dcb03b76ef3e9db3220dce1e682bc23c and https://github.com/pydata/xarray/pull/5692/commits/a891e22d33ae6553db8b2d58cf0522a92f21dd5d). Also, multi-index level coordinates become real coordinates so we don't need keep_attrs to handle the coordinate attributes, we can just propagate the attributes of each of the coordinates unambiguously.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Respect keep_attrs when using `Dataset.set_index` (#4955) 1050367667
977664709 https://github.com/pydata/xarray/pull/5972#issuecomment-977664709 https://api.github.com/repos/pydata/xarray/issues/5972 IC_kwDOAMm_X846RfrF mathause 10194086 2021-11-24T08:54:46Z 2021-11-24T08:54:46Z MEMBER

I just saw that the merge_indexes function gets removed in #5692. So I am not sure it makes sense to fix this here?

@benbovy FYI.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Respect keep_attrs when using `Dataset.set_index` (#4955) 1050367667
977586913 https://github.com/pydata/xarray/pull/5972#issuecomment-977586913 https://api.github.com/repos/pydata/xarray/issues/5972 IC_kwDOAMm_X846RMrh mathause 10194086 2021-11-24T07:00:38Z 2021-11-24T07:00:38Z MEMBER

5957 seems to have snuck in - can you merge master?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Respect keep_attrs when using `Dataset.set_index` (#4955) 1050367667

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);