issue_comments: 977743927

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5972#issuecomment-977743927 https://api.github.com/repos/pydata/xarray/issues/5972 977743927 IC_kwDOAMm_X846RzA3 4160723 2021-11-24T10:31:11Z 2021-11-24T10:31:11Z MEMBER

Thanks for pinging me @mathause. And sorry @gcaria I didn't see #4955 and this PR until now.

Indeed, there's no need for a fix considering that in #5692 variable attributes are now propagated properly through set_index and other operations on indexes (see https://github.com/pydata/xarray/pull/5692/commits/0086e326dcb03b76ef3e9db3220dce1e682bc23c and https://github.com/pydata/xarray/pull/5692/commits/a891e22d33ae6553db8b2d58cf0522a92f21dd5d). Also, multi-index level coordinates become real coordinates so we don't need keep_attrs to handle the coordinate attributes, we can just propagate the attributes of each of the coordinates unambiguously.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1050367667