issue_comments

Table actions

4 rows where issue = 103055174 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 4 ✖

issue 1

  • raise error if dataarray.name is wrong type · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
136812613 https://github.com/pydata/xarray/pull/551#issuecomment-136812613 https://api.github.com/repos/pydata/xarray/issues/551 MDEyOklzc3VlQ29tbWVudDEzNjgxMjYxMw== shoyer 1217238 2015-09-01T17:58:35Z 2015-09-01T17:58:35Z MEMBER

@jhamman The problem is these lines in Dataset.__getitem__: https://github.com/xray/xray/blob/v0.6.0/xray/core/dataset.py#L615-L619

We should probably be checking for is_hashable(key) instead of converting to an ndarray, where is_hashable looks something like this: http://stackoverflow.com/a/3460725/809705

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   raise error if dataarray.name is wrong type 103055174
136121187 https://github.com/pydata/xarray/pull/551#issuecomment-136121187 https://api.github.com/repos/pydata/xarray/issues/551 MDEyOklzc3VlQ29tbWVudDEzNjEyMTE4Nw== shoyer 1217238 2015-08-30T09:51:03Z 2015-08-30T09:51:03Z MEMBER

I'm conflicted about this change. My concern is that the only strict requirement for making a dataset is that the variable names must be hashable (and unique). Yes, you certainly need strings to write netcdfs -- but that's not something everyone uses, and it's usually not much more distruptive to get the error in to_netcdf rather than when creating the dataset. I don't think there are many other places in the code where we need to verify that variable name is a string?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   raise error if dataarray.name is wrong type 103055174
135143450 https://github.com/pydata/xarray/pull/551#issuecomment-135143450 https://api.github.com/repos/pydata/xarray/issues/551 MDEyOklzc3VlQ29tbWVudDEzNTE0MzQ1MA== shoyer 1217238 2015-08-26T19:13:18Z 2015-08-26T19:13:18Z MEMBER

Nope, the elements in new_coords_names are a subset of the keys of new_variables.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   raise error if dataarray.name is wrong type 103055174
135139591 https://github.com/pydata/xarray/pull/551#issuecomment-135139591 https://api.github.com/repos/pydata/xarray/issues/551 MDEyOklzc3VlQ29tbWVudDEzNTEzOTU5MQ== shoyer 1217238 2015-08-26T18:58:49Z 2015-08-26T18:58:49Z MEMBER

I think you can put the Dataset checks in _update_vars_and_coords (on the keys of new_variables). That method gets called at the lowest level by everything that adds variables.

Note, for example, that you can also create new variables by passing a dictionary into Dataset.merge or Dataset.update.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   raise error if dataarray.name is wrong type 103055174

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);