issue_comments: 136121187
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/551#issuecomment-136121187 | https://api.github.com/repos/pydata/xarray/issues/551 | 136121187 | MDEyOklzc3VlQ29tbWVudDEzNjEyMTE4Nw== | 1217238 | 2015-08-30T09:51:03Z | 2015-08-30T09:51:03Z | MEMBER | I'm conflicted about this change. My concern is that the only strict requirement for making a dataset is that the variable names must be hashable (and unique). Yes, you certainly need strings to write netcdfs -- but that's not something everyone uses, and it's usually not much more distruptive to get the error in to_netcdf rather than when creating the dataset. I don't think there are many other places in the code where we need to verify that variable name is a string? |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
103055174 |