issue_comments

Table actions

4 rows where issue = 102840892 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • cast DataArray name to string if not None · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
134637212 https://github.com/pydata/xarray/pull/549#issuecomment-134637212 https://api.github.com/repos/pydata/xarray/issues/549 MDEyOklzc3VlQ29tbWVudDEzNDYzNzIxMg== jhamman 2443309 2015-08-25T15:46:39Z 2015-08-25T15:46:39Z MEMBER

@shoyer -

Maybe the only place to silently convert is in the to_dataset method of DataArray, when splitting an existing dimension to create a dataset with new variables? Otherwise that method is not guaranteed to succeed, which seems like a Bad Thing.

If you are splitting a dataset along a dimension, we don't use the name argument: https://github.com/xray/xray/blob/master/xray/core/dataarray.py#L243-L273. So I don't think any changes are needed in that case. In fact, in _to_dataset_split(), the labels are cast to strings.

I'm going to close this PR and open a new one with errors raised instead of silently converting. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cast DataArray name to string if not None 102840892
134399426 https://github.com/pydata/xarray/pull/549#issuecomment-134399426 https://api.github.com/repos/pydata/xarray/issues/549 MDEyOklzc3VlQ29tbWVudDEzNDM5OTQyNg== shoyer 1217238 2015-08-24T22:26:49Z 2015-08-24T22:26:49Z MEMBER

Indeed, I think it's better to raise than silently convert -- that's much more Pythonic.

The keys of a dataset would be the other place to enforce this.

Maybe the only place to silently convert is in the to_dataset method of DataArray, when splitting an existing dimension to create a dataset with new variables? Otherwise that method is not guaranteed to succeed, which seems like a Bad Thing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cast DataArray name to string if not None 102840892
134364506 https://github.com/pydata/xarray/pull/549#issuecomment-134364506 https://api.github.com/repos/pydata/xarray/issues/549 MDEyOklzc3VlQ29tbWVudDEzNDM2NDUwNg== jhamman 2443309 2015-08-24T20:18:30Z 2015-08-24T20:18:30Z MEMBER

I'm happy to raise an error instead. I may have misunderstood @shoyer's comment in #533.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cast DataArray name to string if not None 102840892
134362572 https://github.com/pydata/xarray/pull/549#issuecomment-134362572 https://api.github.com/repos/pydata/xarray/issues/549 MDEyOklzc3VlQ29tbWVudDEzNDM2MjU3Mg== clarkfitzg 5356122 2015-08-24T20:10:12Z 2015-08-24T20:10:12Z MEMBER

You mentioned in the bug report:

Another way is just to raise an error if a not string variable name is used.

Raising a TypeError seems like the way to go here, since str works on anything. Relevant line in 'Zen':

In the face of ambiguity, refuse the temptation to guess.

Also, are there other places to implement this? Say the keys of a dataset?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cast DataArray name to string if not None 102840892

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);