issue_comments: 134399426

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/549#issuecomment-134399426 https://api.github.com/repos/pydata/xarray/issues/549 134399426 MDEyOklzc3VlQ29tbWVudDEzNDM5OTQyNg== 1217238 2015-08-24T22:26:49Z 2015-08-24T22:26:49Z MEMBER

Indeed, I think it's better to raise than silently convert -- that's much more Pythonic.

The keys of a dataset would be the other place to enforce this.

Maybe the only place to silently convert is in the to_dataset method of DataArray, when splitting an existing dimension to create a dataset with new variables? Otherwise that method is not guaranteed to succeed, which seems like a Bad Thing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   102840892