issue_comments

Table actions

5 rows where issue = 101719623 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • jhamman · 5 ✖

issue 1

  • Fix contour color · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
136810234 https://github.com/pydata/xarray/pull/538#issuecomment-136810234 https://api.github.com/repos/pydata/xarray/issues/538 MDEyOklzc3VlQ29tbWVudDEzNjgxMDIzNA== jhamman 2443309 2015-09-01T17:48:12Z 2015-09-01T17:48:12Z MEMBER

Thanks @rabernat . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix contour color 101719623
136521381 https://github.com/pydata/xarray/pull/538#issuecomment-136521381 https://api.github.com/repos/pydata/xarray/issues/538 MDEyOklzc3VlQ29tbWVudDEzNjUyMTM4MQ== jhamman 2443309 2015-08-31T22:52:49Z 2015-08-31T22:52:49Z MEMBER

@rabernat and @shoyer -

Sorry I've been mostly absent in this conversation recently. I'm currently buried under a mound of C and Fortran code.

I included the optional seaborn call in the discrete colormap/colorbar PR to expose a few nice features in the seaborn color_palette api. Namely, I wanted access to all the seaborn named color palettes and to be able to pass a list of custom colors.

I would be okay with adding the palette argument but it seems a bit excessive since palette, cmap, and colors are all basically orthogonal. We don't have to stick to the matplotlib or seaborn api. I understand the hesitation to overload any one of these parameters.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix contour color 101719623
135514411 https://github.com/pydata/xarray/pull/538#issuecomment-135514411 https://api.github.com/repos/pydata/xarray/issues/538 MDEyOklzc3VlQ29tbWVudDEzNTUxNDQxMQ== jhamman 2443309 2015-08-27T18:26:16Z 2015-08-27T18:26:16Z MEMBER

You are correct. We should create a colormap if seaborn is not installed. The relevant line is here: https://github.com/rabernat/xray/blob/fix_contour_color/xray/plot/plot.py#L300

where we could add something like this sudo code:

python if isinstance(cmap, list-like-thing): cmap = _cmap_from_list_of_colors(cmap)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix contour color 101719623
135196387 https://github.com/pydata/xarray/pull/538#issuecomment-135196387 https://api.github.com/repos/pydata/xarray/issues/538 MDEyOklzc3VlQ29tbWVudDEzNTE5NjM4Nw== jhamman 2443309 2015-08-26T22:31:47Z 2015-08-26T22:31:47Z MEMBER

Do we want to make seaborn a mandatory dependency for plotting?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix contour color 101719623
134257862 https://github.com/pydata/xarray/pull/538#issuecomment-134257862 https://api.github.com/repos/pydata/xarray/issues/538 MDEyOklzc3VlQ29tbWVudDEzNDI1Nzg2Mg== jhamman 2443309 2015-08-24T15:50:48Z 2015-08-24T15:50:48Z MEMBER

I have no problems with this. @clarkfitzg - any more thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix contour color 101719623

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);