issue_comments: 136521381

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/538#issuecomment-136521381 https://api.github.com/repos/pydata/xarray/issues/538 136521381 MDEyOklzc3VlQ29tbWVudDEzNjUyMTM4MQ== 2443309 2015-08-31T22:52:49Z 2015-08-31T22:52:49Z MEMBER

@rabernat and @shoyer -

Sorry I've been mostly absent in this conversation recently. I'm currently buried under a mound of C and Fortran code.

I included the optional seaborn call in the discrete colormap/colorbar PR to expose a few nice features in the seaborn color_palette api. Namely, I wanted access to all the seaborn named color palettes and to be able to pass a list of custom colors.

I would be okay with adding the palette argument but it seems a bit excessive since palette, cmap, and colors are all basically orthogonal. We don't have to stick to the matplotlib or seaborn api. I understand the hesitation to overload any one of these parameters.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   101719623