issue_comments

Table actions

3 rows where author_association = "NONE" and issue = 195832230 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • Set a default _FillValue of NaN for float types · 3 ✖

author_association 1

  • NONE · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
332833849 https://github.com/pydata/xarray/pull/1165#issuecomment-332833849 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDMzMjgzMzg0OQ== mmartini-usgs 23199378 2017-09-28T13:20:12Z 2017-09-28T13:20:12Z NONE

It is not desirable for us to have _FillValue = NaN for dimensions and coordinate variables.

In trying to use xarray, _FillValue was carefully kept from these variables and dimensions during the creation of the un-resampled file and then were found to appear during the to_netcdf operation. This happens in spite of mask_and_scale=False is being used with xr.open_dataset

I would hope that downstream code would have trouble with coordinates that don't make logical sense (time or place being NaN, for instance). We would prefer NOT to instantiate coordinate variable data with any fill value. Keeping NaNs out of coordinate variables, dimensions and minima and maxima is part of our QA/QC process to avoid downstream issues.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230
321890019 https://github.com/pydata/xarray/pull/1165#issuecomment-321890019 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDMyMTg5MDAxOQ== thenaomig 11436996 2017-08-11T18:45:14Z 2017-08-11T18:45:14Z NONE

At the moment, I am only concerned with coordinate variables. I suppose it would be less likely to come up otherwise, but someone might want to leave it off for any variable.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230
321882272 https://github.com/pydata/xarray/pull/1165#issuecomment-321882272 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDMyMTg4MjI3Mg== thenaomig 11436996 2017-08-11T18:10:45Z 2017-08-11T18:10:45Z NONE

Is there a way to override this default behavior and write a netCDF file without including _FillValue in the metadata? For example, if one were adhering to a requested output format that does not include this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);