home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 332833849

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1165#issuecomment-332833849 https://api.github.com/repos/pydata/xarray/issues/1165 332833849 MDEyOklzc3VlQ29tbWVudDMzMjgzMzg0OQ== 23199378 2017-09-28T13:20:12Z 2017-09-28T13:20:12Z NONE

It is not desirable for us to have _FillValue = NaN for dimensions and coordinate variables.

In trying to use xarray, _FillValue was carefully kept from these variables and dimensions during the creation of the un-resampled file and then were found to appear during the to_netcdf operation. This happens in spite of mask_and_scale=False is being used with xr.open_dataset

I would hope that downstream code would have trouble with coordinates that don't make logical sense (time or place being NaN, for instance). We would prefer NOT to instantiate coordinate variable data with any fill value. Keeping NaNs out of coordinate variables, dimensions and minima and maxima is part of our QA/QC process to avoid downstream issues.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  195832230
Powered by Datasette · Queries took 76.718ms · About: xarray-datasette