issue_comments

Table actions

3 rows where author_association = "NONE" and issue = 1389176083 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Don't cast NaN to integer · 3 ✖

author_association 1

  • NONE · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1510407267 https://github.com/pydata/xarray/pull/7098#issuecomment-1510407267 https://api.github.com/repos/pydata/xarray/issues/7098 IC_kwDOAMm_X85aBvxj kxxt 18085551 2023-04-16T15:01:24Z 2023-04-16T15:01:24Z NONE

Hi, is there any reason that keeps this pr from being merged? This PR is a fix for some failing tests on riscv64.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Don't cast NaN to integer 1389176083
1262637254 https://github.com/pydata/xarray/pull/7098#issuecomment-1262637254 https://api.github.com/repos/pydata/xarray/issues/7098 IC_kwDOAMm_X85LQlDG andreas-schwab 2175493 2022-09-29T18:08:29Z 2022-09-29T18:08:29Z NONE

That's the beauty of undefined behaviour. It comes in many flavors, and you never know which one you get. Which also means that it is impossible to reliably test for it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Don't cast NaN to integer 1389176083
1262568339 https://github.com/pydata/xarray/pull/7098#issuecomment-1262568339 https://api.github.com/repos/pydata/xarray/issues/7098 IC_kwDOAMm_X85LQUOT andreas-schwab 2175493 2022-09-29T17:12:43Z 2022-09-29T17:12:43Z NONE

It's already perfectly covered by the testsuite.

=========================== short test summary info ============================ FAILED xarray/tests/test_backends.py::TestScipyInMemoryData::test_roundtrip_numpy_datetime_data FAILED xarray/tests/test_backends.py::TestScipyFileObject::test_roundtrip_numpy_datetime_data FAILED xarray/tests/test_backends.py::TestGenericNetCDFData::test_roundtrip_numpy_datetime_data FAILED xarray/tests/test_backends.py::TestScipyFilePath::test_roundtrip_numpy_datetime_data = 4 failed, 4636 passed, 5632 skipped, 19 xfailed, 22 xpassed, 38 warnings in 266.18s (0:04:26) =

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Don't cast NaN to integer 1389176083

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);