issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 976790237 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • Make xr.corr and xr.map_blocks work without dask · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
978098589 https://github.com/pydata/xarray/pull/5731#issuecomment-978098589 https://api.github.com/repos/pydata/xarray/issues/5731 IC_kwDOAMm_X846TJmd shoyer 1217238 2021-11-24T17:48:52Z 2021-11-24T17:48:52Z MEMBER

I have a follow-up PR that simplifies the internal logic a little bit more: https://github.com/pydata/xarray/pull/6025

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make xr.corr and xr.map_blocks work without dask 976790237
977243782 https://github.com/pydata/xarray/pull/5731#issuecomment-977243782 https://api.github.com/repos/pydata/xarray/issues/5731 IC_kwDOAMm_X846P46G shoyer 1217238 2021-11-23T22:47:30Z 2021-11-23T22:47:30Z MEMBER

Checking in here -- it seems like this PR surfaced an existing bug (incorrect calculation of correlation when using dask), at the same time as it corrected a different bug, which is removing the hard dependency on dask for calculating correlation?

If I'm understanding correctly, this is still a net win (fixing one bug), so it probably makes sense to merge it now and save the other bug fix for a later issue?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make xr.corr and xr.map_blocks work without dask 976790237

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);