home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 977243782

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5731#issuecomment-977243782 https://api.github.com/repos/pydata/xarray/issues/5731 977243782 IC_kwDOAMm_X846P46G 1217238 2021-11-23T22:47:30Z 2021-11-23T22:47:30Z MEMBER

Checking in here -- it seems like this PR surfaced an existing bug (incorrect calculation of correlation when using dask), at the same time as it corrected a different bug, which is removing the hard dependency on dask for calculating correlation?

If I'm understanding correctly, this is still a net win (fixing one bug), so it probably makes sense to merge it now and save the other bug fix for a later issue?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  976790237
Powered by Datasette · Queries took 81.166ms · About: xarray-datasette