issue_comments

Table actions

2 rows where author_association = "MEMBER" and issue = 974659059 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Added get_options method · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
902286066 https://github.com/pydata/xarray/pull/5716#issuecomment-902286066 https://api.github.com/repos/pydata/xarray/issues/5716 IC_kwDOAMm_X841x8ry max-sixty 5635139 2021-08-19T22:13:32Z 2021-08-19T22:13:32Z MEMBER

This looks good., thanks @pkopparla Thanks for reviewing @Illviljan .

Agree re a test — at least to just test it runs, albeit trivial.

FrozenDict would be better, though I think fine to do in another PR. We could return dict(OPTIONS) if we're worried people will attempt to set invalid values.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added get_options method 974659059
902010417 https://github.com/pydata/xarray/pull/5716#issuecomment-902010417 https://api.github.com/repos/pydata/xarray/issues/5716 IC_kwDOAMm_X841w5Yx Illviljan 14371165 2021-08-19T15:27:44Z 2021-08-19T15:27:44Z MEMBER

The returned dict should be read only, otherwise you can bypass all the validation checks that's done in set_options. I think you can use FrozenDict for that: https://github.com/pydata/xarray/blob/56cc0778d5edcb0173425b5850b834457c790210/xarray/core/utils.py#L476 Not sure if FrozenDict propagates the typing though, once OPTIONS is typed.

We probably need to make sure that get_options is updated if set_options has been used. A test for that would be nice.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added get_options method 974659059

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);